Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): no need to run pnpm cache when building binary #9431

Closed
wants to merge 1 commit into from
Closed

chore(workflow): no need to run pnpm cache when building binary #9431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions .github/workflows/reusable-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ jobs:
with:
target: ${{ inputs.target }}

- name: Pnpm Cache
if: ${{ !inputs.skipable }}
uses: ./.github/actions/pnpm-cache
with:
save-if: ${{ github.ref_name == 'main' }}

- name: Install Rust Toolchain
if: ${{ !inputs.skipable }}
uses: ./.github/actions/rustup
Expand Down Expand Up @@ -260,7 +254,7 @@ jobs:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: true
# TODO: use puppeteer to test SRI Plugin, maybe find a better performance way
# PUPPETEER_SKIP_DOWNLOAD: true

steps:
- name: Checkout
if: ${{ !inputs.skipable }}
Expand Down Expand Up @@ -379,7 +373,7 @@ jobs:
with:
save-cache: ${{ github.ref_name == 'main' }} # This should be safe because we have nightly building the cache every day
shared-key: build-bench-${{ inputs.target }}-${{ inputs.profile }}

- name: Install cargo-codspeed binary
uses: taiki-e/install-action@54b836426b3fa9aef432e760885ea0419ab50dab # v2
with:
Expand All @@ -394,10 +388,10 @@ jobs:
uses: lewagon/[email protected]
with:
ref: ${{ github.event.pull_request.head.sha || github.sha }}
check-name: 'Test Linux / Build'
check-name: "Test Linux / Build"
repo-token: ${{ secrets.GITHUB_TOKEN }}
wait-interval: 10

- name: Download bindings
uses: ./.github/actions/download-artifact
with:
Expand Down
Loading