-
Notifications
You must be signed in to change notification settings - Fork 1
Adds new package.json config option with README explainer #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Better syntax for merging config objects, thanks @notpushkin Co-authored-by: Alexander Pushkov <[email protected]>
Update logic for retrieving package.json Co-authored-by: Alexander Pushkov <[email protected]>
…s conflicting configs between extends and package.json
Alright, I think this should do the trick! I do have one more proposal, but if you want to unblock that Angular issue faster we can discuss it separately. What if we merge {
"target": "2020", // → 2020-12-31 - last day of year
"target": "2020-04", // → 2020-04-30 - last day of month
"target": "2020-04-02", // → 2020-04-02 - fixed date
} This is a bit trickier to implement, but I think it would be so much more streamlined. (On the other side, it would also remove any possibility of As a sidenote, I’ve restructured the README a bit: https://gist.github.com/notpushkin/a809b6796773883a2820c6b1e50d3263 |
|
Perhaps renaming |
Huh. Right. I guess really I haven’t had a lot of sleep lately haha! Yeah, let’s go with |
Right, just made what I think should be the final commit on this change - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Squashing and merging - will run the date update in update-last-updated.js and bump the minor version in main before releasing. FYI, I'm expecting the publish workflow to fail again, unless you've made a change - I'll publish manually if it does fail. |
FAO @notpushkin and @rviscomi
This PR adds a new option for configuring b-c-b using an object in
package.json
.It adds the ability to log your config to the console.
It also adds the ability to set your target as "widely available on YYYY-MM-DD", which was requested by some framework folks.
Fixes #5 sufficiently that I would feel comfortable deprecating bl2bl when this is merged/released - the CLI approach feels unnecessary and I'll only seek to rebuild it if people are clamouring for it.