Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add popover=hint feature #2680

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Add popover=hint feature #2680

merged 3 commits into from
Feb 21, 2025

Conversation

mfreed7
Copy link
Contributor

@mfreed7 mfreed7 commented Feb 20, 2025

Closes #2250

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Feb 20, 2025
ddbeck
ddbeck requested changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this, @mfreed7! I've got a few suggestions for you, but I expect we'll able to merge this quickly.

ddbeck
ddbeck approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ddbeck ddbeck merged commit 8362f13 into web-platform-dx:main Feb 21, 2025
3 checks passed
aarongable pushed a commit to chromium/chromium that referenced this pull request Feb 21, 2025
@mfreed7
Add WebDx use counter for popover=hint
df141a9 
See:
- web-platform-dx/web-features#2680
- web-platform-dx/web-features#2250

Note that the PR above hasn't landed yet, and I don't know what the
proper sequencing is there, or even how to connect `kPopoverHint`
over to the new entry I added above.

Bug: 40256776
Change-Id: Ibfae2d2dc550ed809a4b0bfb4924c94d4899125a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6284402
Reviewed-by: Philip Jägenstedt <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1423250}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add popover=hint feature
2 participants
@mfreed7 @ddbeck