Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadableStream: Reject pending reads when releasing reader #34751

Closed
wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

Previously, calling releaseLock() on ReadableStreamDefaultReader or
ReadableStreamBYOBReader while there are pending read requests would
throw a TypeError. The specification has been changed[1] to allow this
case, and to reject such pending read requests with a TypeError
instead.

[1] whatwg/streams#1168

Bug: 1287273
Change-Id: Id4013571212e20b0d6ecccdcf68cd6d3927d38b2

Reviewed-on: https://chromium-review.googlesource.com/3750760
WPT-Export-Revision: 036e15e4ee74147a2c2a81899c546d016dba7825

Previously, calling releaseLock() on ReadableStreamDefaultReader or
ReadableStreamBYOBReader while there are pending read requests would
throw a TypeError. The specification has been changed[1] to allow this
case, and to reject such pending read requests with a TypeError
instead.

[1] whatwg/streams#1168

Bug: 1287273
Change-Id: Id4013571212e20b0d6ecccdcf68cd6d3927d38b2
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot
Copy link
Collaborator Author

Close this PR because the Chromium CL does not have exportable changes.

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-3750760 branch May 5, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants