Shared Storage: Add non-live dataOption to createWorklet for use counter #46853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We proposed a breaking change to sharedStorage.createWorklet() in WICG/shared-storage#158. We add a use counter for how frequently createWorklet is called in a non-forward-compatible way according to the proposal (i.e. with a cross-origin script but without the option dataOrigin: "script- origin"). This will help us determine what the impact of this change would be. Bug: 348445878 Change-Id: I3b882a9ec859beb5265ba31d3169fb5e1239cac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645568 Reviewed-by: Yao Xiao <[email protected]> Commit-Queue: Cammie Smith Barnes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1318000}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5645568
branch
from
cf9cea1 to
2c4acbb
Compare
wpt-pr-bot
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We proposed a breaking change to sharedStorage.createWorklet() in
WICG/shared-storage#158.
We add a use counter for how frequently createWorklet is called in a
non-forward-compatible way according to the proposal (i.e. with a
cross-origin script but without the option dataOrigin: "script-
origin"). This will help us determine what the impact of this change
would be.
Bug: 348445878
Change-Id: I3b882a9ec859beb5265ba31d3169fb5e1239cac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5645568
Reviewed-by: Yao Xiao <[email protected]>
Commit-Queue: Cammie Smith Barnes <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1318000}