Remove ::select-fallback-button #48228
Merged
+0
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes customizable <select>'s fallback <button> element in the UA shadowroot by replacing it with the same "InnerElement" <div> which is used for appearance:auto. Several supporting changes were made in order to implement this: - Also remove ::select-fallback-button-text - Add -internal-appearance-auto-base-select() support for the following properties: - min-block-size - min-inline-size - padding-block-start - padding-block-end - padding-inline-start - padding-inline-end - content in select::after - Make <select> focusable again when there is no child <button> element - Remove dependency on popover triggering code in HTMLFormControlElement now that we aren't always opening the popover with a <button> This is in response to feedback here: w3c/csswg-drafts#10717 This also addresses additional feedback I received privately that author styles applied to the select element itself weren't applying to the in-page portion of the element. Change-Id: I0a833b370babe9a8ab937822a3578d839510a8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786670 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1356701}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5786670
branch
from
a991740 to
c68c3fe
Compare
wpt-pr-bot
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes customizable <select>'s fallback <button> element in
the UA shadowroot by replacing it with the same "InnerElement" <div>
which is used for appearance:auto.
Several supporting changes were made in order to implement this:
properties:
now that we aren't always opening the popover with a <button>
This is in response to feedback here:
w3c/csswg-drafts#10717
This also addresses additional feedback I received privately that author
styles applied to the select element itself weren't applying to the
in-page portion of the element.
Change-Id: I0a833b370babe9a8ab937822a3578d839510a8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5786670
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1356701}