Fenced frame: Add tests for component ad automatic beacon data. #50062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Component ads are not allowed to set automatic beacon data. This CL verifies that behavior by expanding 2 existing tests to check the path that overrides beacon data that is set from ad components. These tests are needed now that cross-origin subframes are allowed to set automatic beacon data; we still need ad components to be restricted from this feature. Bug: 382500834 Change-Id: I05776cc96896f4f8fa5062dbcca3eaf9e85d9a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6172872 Reviewed-by: Shivani Sharma <[email protected]> Commit-Queue: Liam Brady <[email protected]> Reviewed-by: Xiaochen Zhou <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1406726}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6172872
branch
from
2bab62c to
ee39e8d
Compare
wpt-pr-bot
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component ads are not allowed to set automatic beacon data. This CL
verifies that behavior by expanding 2 existing tests to check the path
that overrides beacon data that is set from ad components.
These tests are needed now that cross-origin subframes are allowed to
set automatic beacon data; we still need ad components to be restricted
from this feature.
Bug: 382500834
Change-Id: I05776cc96896f4f8fa5062dbcca3eaf9e85d9a66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6172872
Reviewed-by: Shivani Sharma <[email protected]>
Commit-Queue: Liam Brady <[email protected]>
Reviewed-by: Xiaochen Zhou <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1406726}