Add support for product plugins to wptrunner/wpt run#58022
Open
gsnedders wants to merge 8 commits intoweb-platform-tests:masterfrom
Open
Add support for product plugins to wptrunner/wpt run#58022gsnedders wants to merge 8 commits intoweb-platform-tests:masterfrom
gsnedders wants to merge 8 commits intoweb-platform-tests:masterfrom
Conversation
By moving the dataclass to a base class we can simply call the dataclass generated __init__ on the superclass, rather than having to do it all manually. All of the logic is now within dataclass; all the Product subclass does is maintain support for the deprecated constructor, and provides the from_product_name method.
gsnedders
force-pushed
the
wptrunner_product_plugins
branch
from
9d39828 to
3b512e5
Compare
wpt-pr-bot
added
docs
infra
wpt
wptrunner
wpt-pr-bot
requested review from
DanielRyanSmith,
foolip,
jonathan-j-lee and
sideshowbarker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on top of #57503, adding the ability to define products external to wptrunner. It probably makes sense to review that (the first commit on this branch) separately.