DNS server support for wptrunner#58024
Open
gsnedders wants to merge 2 commits intoweb-platform-tests:masterfrom
Open
DNS server support for wptrunner#58024gsnedders wants to merge 2 commits intoweb-platform-tests:masterfrom
gsnedders wants to merge 2 commits intoweb-platform-tests:masterfrom
Conversation
Primarily just an exercising in hooking things up to `serve.start()`. Add --enable-dns / --no-enable-dns command-line arguments to users to enable the DNS server; this operates similar to --enable-webtransport-h3 which already exists.
When enable_dns or enable_webtransport_h3 are not provided via command-line arguments (i.e., they are None), check product.env_options for these values. This allows products to set sensible defaults via their env_options() function while still allowing command-line arguments to take precedence.
wpt-pr-bot
added
infra
wptrunner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if it makes sense to have both of these commits — I'm not sure when
--enable-dnsmight be a sensible thing to pass, despite it following the pattern of the rest of the servers, though it is clearly somewhat different.