[wptrunner] Coerce script timeout to integer for non-wdspec tests#58026
Open
jonathan-j-lee wants to merge 1 commit intoweb-platform-tests:masterfrom
Open
[wptrunner] Coerce script timeout to integer for non-wdspec tests#58026jonathan-j-lee wants to merge 1 commit intoweb-platform-tests:masterfrom
jonathan-j-lee wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
https://crrev.com/c/7522226 seems to have caused Chrome on iOS results to disappear from wpt.fyi because the final timeout is [fractional]: ``` webdriver.error.InvalidArgumentException: invalid argument (500): Timeouts must be non-negative integers ``` This can be replicated with the right `wpt run --timeout-multiplier`, so avoid fractional timeouts in general. The spec for "Set Timeouts" isn't clear on how they should be handled (w3c/webdriver#1949), but the de facto behavior is to return "invalid argument". Note that the WebDriver client can still send fractional timeouts to test invalid values. [fractional]: https://chromium-swarm.appspot.com/task?id=7673a57e106bad10&w=true
jonathan-j-lee
force-pushed
the
wptrunner/timeout-int
branch
from
b75aa0e to
2105ea6
Compare
wpt-pr-bot
added
infra
wptrunner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://crrev.com/c/7522226 seems to have caused Chrome on iOS results to disappear from wpt.fyi because the final timeout is fractional:
This can be replicated with the right
wpt run --timeout-multiplier, so avoid fractional timeouts in general. The spec for "Set Timeouts" isn't clear on how they should be handled (w3c/webdriver#1949), but the de facto behavior is to return "invalid argument".Note that the WebDriver client can still send fractional timeouts to test invalid values.