Picture-in-Picture test not waiting for event handler to run#58039
Open
theIDinside wants to merge 2 commits intoweb-platform-tests:masterfrom
Open
Picture-in-Picture test not waiting for event handler to run#58039theIDinside wants to merge 2 commits intoweb-platform-tests:masterfrom
theIDinside wants to merge 2 commits intoweb-platform-tests:masterfrom
Conversation
Fix the tests that passed on browsers without ever hitting the asserts because we did not wait for them to run.
…s because we did not wait
| video.addEventListener('leavepictureinpicture', t.step_func_done(event => { | ||
| assert_equals(pictureInPictureWindow, event.pictureInPictureWindow); | ||
| const leavePipPromise = new Promise(resolve => { | ||
| video.addEventListener('leavepictureinpicture', t.step_func(event => { |
Contributor
There was a problem hiding this comment.
Why not step_func_done there?
| let pictureInPictureWindow; | ||
| const video = await loadVideo(); | ||
|
|
||
| video.addEventListener('enterpictureinpicture', t.step_func_done(event => { |
Contributor
There was a problem hiding this comment.
Should it be t.step_func instead?
| })); | ||
| }); | ||
|
|
||
| await requestPictureInPictureWithTrustedClick(video) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See what the attribute says in the spec: https://w3c.github.io/picture-in-picture/#disable-pip:~:text=so%2E-,When,algorithm%2E and discussion w3c/picture-in-picture#184
This PR also addresses both the newly created one and the only one to actually wait for the event handler to execute so to not pass without running them as before.
This closes #58040