[Masonry] Simplify subgrid wpt tests#58059
Open
jonathan-j-lee wants to merge 1 commit intoweb-platform-tests:masterfrom
Open
[Masonry] Simplify subgrid wpt tests#58059jonathan-j-lee wants to merge 1 commit intoweb-platform-tests:masterfrom
jonathan-j-lee wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
The existing subgrid wpt tests under grid-lanes were split into column and row folders, but marked tests that used rows as column and vice versa. Swap the folder names, and update the tests to remove the use for a .rows class to describe columns. Instead, just use grid-template- rows/columns where intended. Also remove styles that weren't being used in various tests. Note: all edits to ref files were because of the folder renames, otherwise, those were not touched. This change has no behavioral impact, just makes the tests easier to reason about. Bug: 343257585 Change-Id: Ic5da2f3607738c869fbf804ae5033d5c742bcd95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7608631 Commit-Queue: Alison Maher <almaher@microsoft.com> Auto-Submit: Alison Maher <almaher@microsoft.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1590422}
wpt-pr-bot
requested review from
fantasai,
javifernandez,
plinss,
rachelandrew,
svillar and
tabatkins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing subgrid wpt tests under grid-lanes were split into column and row folders, but marked tests that used rows as column and vice versa. Swap the folder names, and update the tests to remove the use for a .rows class to describe columns. Instead, just use grid-template- rows/columns where intended. Also remove styles that weren't being used in various tests.
Note: all edits to ref files were because of the folder renames, otherwise, those were not touched.
This change has no behavioral impact, just makes the tests easier to reason about.
Bug: 343257585
Change-Id: Ic5da2f3607738c869fbf804ae5033d5c742bcd95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7608631
Commit-Queue: Alison Maher almaher@microsoft.com
Auto-Submit: Alison Maher almaher@microsoft.com
Commit-Queue: Ian Kilpatrick ikilpatrick@chromium.org
Reviewed-by: Ian Kilpatrick ikilpatrick@chromium.org
Cr-Commit-Position: refs/heads/main@{#1590422}
Manual export of https://crrev.com/c/7608631 due to conflict with #57972. The changes look orthogonal though, so I kept both.