Skip to content

Navigation-Timing: destination-based TAO#60823

Merged
jcscottiii merged 1 commit into
masterfrom
chromium-export-cl-7915892
Jun 24, 2026
Merged

Navigation-Timing: destination-based TAO#60823
jcscottiii merged 1 commit into
masterfrom
chromium-export-cl-7915892

Conversation

@chromium-wpt-export-bot

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This CL implements whatwg/html#12513 and
whatwg/fetch#1931, in order to resolve
w3c/navigation-timing#215.

It enables developers to opt-in to get cross-origin redirect timings,
through destination-based Timing-Allow-Origin headers.

I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/GOPn8-wQlsk/m/x5Q3G6KuAgAJ

Change-Id: Ib463010f1862af523a241d2e9180ff09bfedb101
Bug: 521861828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7915892
Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org>
Reviewed-by: Noam Rosenthal <nrosenthal@google.com>
Cr-Commit-Position: refs/heads/main@{#1650808}

This CL implements whatwg/html#12513 and
whatwg/fetch#1931, in order to resolve
w3c/navigation-timing#215.

It enables developers to opt-in to get cross-origin redirect timings,
through destination-based Timing-Allow-Origin headers.

I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/GOPn8-wQlsk/m/x5Q3G6KuAgAJ

Change-Id: Ib463010f1862af523a241d2e9180ff09bfedb101
Bug: 521861828
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7915892
Commit-Queue: Yoav Weiss (@Shopify) <yoavweiss@chromium.org>
Reviewed-by: Noam Rosenthal <nrosenthal@google.com>
Cr-Commit-Position: refs/heads/main@{#1650808}

@wpt-pr-bot wpt-pr-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@community-tc-integration

Copy link
Copy Markdown
Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/U_LzDU7uTpa1qmg0dmwL4g/HSgqB5abTteG5oBvojSjvA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/U_LzDU7uTpa1qmg0dmwL4g"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/U_LzDU7uTpa1qmg0dmwL4g/HSgqB5abTteG5oBvojSjvA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/U_LzDU7uTpa1qmg0dmwL4g"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2026-06-23T15:42:38.568Z

@community-tc-integration

Copy link
Copy Markdown
Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/U_LzDU7uTpa1qmg0dmwL4g/BrjVsynNQuqiIQWT3IXM1w",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/U_LzDU7uTpa1qmg0dmwL4g"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/U_LzDU7uTpa1qmg0dmwL4g/BrjVsynNQuqiIQWT3IXM1w",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/U_LzDU7uTpa1qmg0dmwL4g"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2026-06-23T15:42:39.122Z

@yoavweiss

Copy link
Copy Markdown
Contributor

@foolip - can you take a look at this?

AFAICT, the firefox flake is unrelated, as it seems to be failing at a test where the only thing this PR changed is the expectation in one of the other test cases.

@yoavweiss

Copy link
Copy Markdown
Contributor

@jcscottiii - As @foolip is OOO, he sent me your way. Can you take a look?

@jcscottiii

Copy link
Copy Markdown
Contributor

@yoavweiss I believe you're right. We will retrigger this. If it still fails, we can force merge.

@jcscottiii
jcscottiii enabled auto-merge (squash) June 24, 2026 13:34
@jcscottiii
jcscottiii merged commit 2b0c3ce into master Jun 24, 2026
46 of 47 checks passed
@jcscottiii
jcscottiii deleted the chromium-export-cl-7915892 branch June 24, 2026 13:36
annevk pushed a commit to whatwg/fetch that referenced this pull request Jun 25, 2026
Timing-Allow-Origin (TAO) currently only opts-in "backwards" in terms of origins and doesn't constitute an opt-in to the destination origin, which is the appropriate opt-in for navigations (contrary to subresources).

This PR adds the mechanisms that can enable such "forward" opt-in, and can enable a navigation response to a redirect chain to know that the redirect chain opted in to expose the redirects to its origin.

Tests: web-platform-tests/wpt#60823 & web-platform-tests/wpt#60873.

Corresponding HTML PR: whatwg/html#12513.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants