Skip to content

Test link rel=compression-dictionary header as early hints#61119

Merged
fred-wang merged 1 commit into
masterfrom
fetch-compression-dictionary-early-hints
Jul 16, 2026
Merged

Test link rel=compression-dictionary header as early hints#61119
fred-wang merged 1 commit into
masterfrom
fetch-compression-dictionary-early-hints

Conversation

@fred-wang

@fred-wang fred-wang commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@fred-wang
fred-wang marked this pull request as draft July 7, 2026 14:36
@fred-wang

fred-wang commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

This is failing in Chromium, which I believe is expected per https://source.chromium.org/chromium/chromium/src/+/main:content/browser/loader/navigation_early_hints_manager.cc;bpv=1;bpt=1;l=406?q=content%2Fbrowser%2Floader%2Fnavigation_early_hints_manager.cc&ss=chromium%2Fchromium%2Fsrc

It's failing too in Igalia's WebKit branch for compression-dictionary, which I guess is expected as we currently don't modify https://searchfox.org/wubkat/rev/d221d71a6a560cb45bb3e9b23e526b6bcfa9e4b3/Source/WebKit/NetworkProcess/EarlyHintsResourceLoader.cpp#67

However, Firefox is failing even though it has some logic here: https://searchfox.org/firefox-main/rev/c86fcb7f22721f58a39455cb965da7634ecf88e6/netwerk/protocol/http/EarlyHintsService.cpp#106 ; so I will need to debug what's happening here edit: firefox now passes the latest version.

@fred-wang
fred-wang force-pushed the fetch-compression-dictionary-early-hints branch 3 times, most recently from c4b1f5e to 403f1ec Compare July 8, 2026 15:22
@fred-wang fred-wang changed the title WIP: link rel=compression-dictionary header as early hints Test link rel=compression-dictionary header as early hints Jul 8, 2026
@fred-wang
fred-wang force-pushed the fetch-compression-dictionary-early-hints branch 2 times, most recently from 78914fa to d7afcb5 Compare July 9, 2026 05:32
@fred-wang

Copy link
Copy Markdown
Contributor Author

cc @TingPing @jesup @annevk @pmeenan

@fred-wang
fred-wang marked this pull request as ready for review July 9, 2026 05:41
@wpt-pr-bot

Copy link
Copy Markdown
Collaborator

There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you!

@fred-wang

Copy link
Copy Markdown
Contributor Author

This PR depends on #61119

@fred-wang
fred-wang requested review from TingPing and pmeenan and removed request for pmeenan July 10, 2026 06:42
@fred-wang
fred-wang force-pushed the fetch-compression-dictionary-early-hints branch from d7afcb5 to 221790a Compare July 10, 2026 20:20
Comment thread fetch/compression-dictionary/resources/compression-dictionary-util.sub.js Outdated
Comment thread fetch/compression-dictionary/resources/compression-dictionary-util.sub.js Outdated
Comment thread fetch/compression-dictionary/resources/compression-dictionary-util.sub.js Outdated
@fred-wang
fred-wang force-pushed the fetch-compression-dictionary-early-hints branch from 221790a to bc3159d Compare July 16, 2026 12:40
@fred-wang
fred-wang force-pushed the fetch-compression-dictionary-early-hints branch from bc3159d to 191f400 Compare July 16, 2026 12:42
@fred-wang
fred-wang requested a review from pmeenan July 16, 2026 12:43

@pmeenan pmeenan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@fred-wang
fred-wang merged commit 27d2ee7 into master Jul 16, 2026
28 checks passed
@fred-wang
fred-wang deleted the fetch-compression-dictionary-early-hints branch July 16, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants