Skip to content

Verify that <link rel="compression-dictionary>" is body-ok#61193

Merged
fred-wang merged 1 commit into
masterfrom
fetch-compression-dictionary-link-in-body
Jul 16, 2026
Merged

Verify that <link rel="compression-dictionary>" is body-ok#61193
fred-wang merged 1 commit into
masterfrom
fetch-compression-dictionary-link-in-body

Conversation

@fred-wang

Copy link
Copy Markdown
Contributor

@fred-wang

Copy link
Copy Markdown
Contributor Author

cc @jesup @pmeenan

This seems to be passing in Firefox, failing Igalia's WebKit branch and flaky in Chromium.

@pmeenan pmeenan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two small nits.

assert_equals(nodes[0].textContent, "Hello");

assert_equals(nodes[1], inBodyLink);
inBodyLinkRect = nodes[1].getBoundingClientRect();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inBodyLinkRect = nodes[1].getBoundingClientRect();
const inBodyLinkRect = nodes[1].getBoundingClientRect();

<script src="./resources/compression-dictionary-util.sub.js"></script>
</head>
<body>
<p id="paragraph">Hello<link id="inBodyLink" rel="compression-dictionary" href="./resources/register-dictionary.py"></link>World!</p>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p id="paragraph">Hello<link id="inBodyLink" rel="compression-dictionary" href="./resources/register-dictionary.py"></link>World!</p>
<p id="paragraph">Hello<link id="inBodyLink" rel="compression-dictionary" href="./resources/register-dictionary.py">World!</p>

@fred-wang fred-wang force-pushed the fetch-compression-dictionary-link-in-body branch from 022a149 to 83aa00b Compare July 16, 2026 10:13
@fred-wang fred-wang merged commit 9bc8141 into master Jul 16, 2026
28 checks passed
@fred-wang fred-wang deleted the fetch-compression-dictionary-link-in-body branch July 16, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants