script: Implement forwarddelete command#61388
Merged
Merged
Conversation
wpt-pr-bot
approved these changes
Jul 18, 2026
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_46608
branch
2 times, most recently
from
July 19, 2026 17:10
406f4b9 to
3fe3018
Compare
Signed-off-by: Psychpsyo (Cameron) <60073468+Psychpsyo@users.noreply.github.com>
servo-wpt-sync
force-pushed
the
servo_export_46608
branch
from
July 20, 2026 09:43
3fe3018 to
379c8c4
Compare
Collaborator
Author
|
⛔ The downstream PR has merged (servo/servo#46608), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
Contributor
|
Seems like CI hasn't finished yet. @jdm can you merge this one once it's all green? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements (most of) the forwarddelete command. Singular TODO about forwarddelete'ing stuff with combining diacritics and such.
Testing: They pass now. Better yet, none of them crash anymore. There is one new timeout though.
I've also taken the liberty to basically rewrite
forwarddelete-after-editable-slot-element-outside-body.html, since we failed it and the test case was a complete mess. Apparently the Firefox people got that one from a fuzzer some years ago and decided to just dump it into WPT without any cleanup: https://bugzilla.mozilla.org/show_bug.cgi?id=1706145Reviewed in servo/servo#46608