[highlights] Fix highlightsFromPoint WPT assertions#61462
Open
chromium-wpt-export-bot wants to merge 1 commit into
Open
[highlights] Fix highlightsFromPoint WPT assertions#61462chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
July 21, 2026 20:36
Correct two no-hit checks that assigned to an unused variable while asserting stale results. Make the invalid StaticRange test retain overlapping live geometry and invalidate the static offset directly, so an incorrectly returned range cannot pass unnoticed. Replace explainer links with the normative Highlight API and CSSOM View sections. Bug: 527784934 Change-Id: I32a624ebd033ce910f04bf2a6c9334eddca6b6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8119492 Auto-Submit: Fernando Fiori <ffiori@microsoft.com> Reviewed-by: Fernando Fiori <ffiori@microsoft.com> Reviewed-by: Stephanie Zhang <stephanie.zhang@microsoft.com> Commit-Queue: Fernando Fiori <ffiori@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1665698}
wpt-pr-bot
approved these changes
Jul 21, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8119492
branch
from
July 21, 2026 20:36
2e4366e to
2e9b9b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct two no-hit checks that assigned to an unused variable while
asserting stale results.
Make the invalid StaticRange test retain overlapping live geometry and
invalidate the static offset directly, so an incorrectly returned range
cannot pass unnoticed.
Replace explainer links with the normative Highlight API and CSSOM View
sections.
Bug: 527784934
Change-Id: I32a624ebd033ce910f04bf2a6c9334eddca6b6fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8119492
Auto-Submit: Fernando Fiori <ffiori@microsoft.com>
Reviewed-by: Fernando Fiori <ffiori@microsoft.com>
Reviewed-by: Stephanie Zhang <stephanie.zhang@microsoft.com>
Commit-Queue: Fernando Fiori <ffiori@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1665698}