Use fuzzy matching in composited-filters-under-opacity.html - #61529
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
July 28, 2026 06:00
https://crrev.com/1665715 changed the reference for composited-filters-under-opacity.html in a way that makes the test not cover the original goals (see: http://crrev.com/653319). This patch reverts https://crrev.com/1665715 and instead adds fuzzy matching, as being off by 1 is fine for this test. Change-Id: I39baa73181fb4ab74243044f1b1e130e6137bf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8145500 Reviewed-by: Keren Zhu <kerenzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1669217}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8145500
branch
from
July 28, 2026 06:00
00c8e0f to
6d70fec
Compare
wpt-pr-bot
approved these changes
Jul 28, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://crrev.com/1665715 changed the reference for
composited-filters-under-opacity.html in a way that makes the test not
cover the original goals (see: http://crrev.com/653319). This patch
reverts https://crrev.com/1665715 and instead adds fuzzy matching, as
being off by 1 is fine for this test.
Change-Id: I39baa73181fb4ab74243044f1b1e130e6137bf34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8145500
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1669217}