Make registerAltDictionaryAndWait more robust and review usages. - #61534
Merged
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8137103
branch
from
July 27, 2026 06:45
a1229a0 to
3e11996
Compare
chromium-wpt-export-bot
marked this pull request as ready for review
July 27, 2026 10:15
Currently, `registerAltDictionaryAndWait()` calls `waitUntilAvailableDictionaryHeader()` which waits until a request to `echo-headers2.py` will be sent with an `available-dictionary` header matching the dictionary hash. This does not properly works if two calls of `registerAltDictionaryAndWait()` are made in the same `compression_dictionary_promise_test`, or can lead to flaky behavior if they are made in the same test file because it can race with test cleanup's cache clearing. To work around these issues, we instead force callers to pass distinct dictionary id and watch for the `Dictionary-ID` header instead. Also improve the documentation are verify call sites adhere to it. Bug: 522338661, 40255884 Change-Id: Ib0945969a4093b2e3abd16b222d2f7ebc2450a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8137103 Reviewed-by: Patrick Meenan <pmeenan@chromium.org> Commit-Queue: Frédéric Wang Nélar <fwang@igalia.com> Cr-Commit-Position: refs/heads/main@{#1668444}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8137103
branch
from
July 27, 2026 10:16
3e11996 to
e5bcd0a
Compare
wpt-pr-bot
approved these changes
Jul 27, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
registerAltDictionaryAndWait()callswaitUntilAvailableDictionaryHeader()which waits until a request toecho-headers2.pywill be sent with anavailable-dictionaryheadermatching the dictionary hash. This does not properly works if two
calls of
registerAltDictionaryAndWait()are made in the samecompression_dictionary_promise_test, or can lead to flaky behaviorif they are made in the same test file because it can race with
test cleanup's cache clearing. To work around these issues, we instead
force callers to pass distinct dictionary id and watch for the
Dictionary-IDheader instead. Also improve the documentation areverify call sites adhere to it.
Bug: 522338661, 40255884
Change-Id: Ib0945969a4093b2e3abd16b222d2f7ebc2450a23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8137103
Reviewed-by: Patrick Meenan <pmeenan@chromium.org>
Commit-Queue: Frédéric Wang Nélar <fwang@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1668444}