[screen-orientation] Test exiting fullscreen unlocks the orientation - #61537
Open
marcoscaceres wants to merge 1 commit into
Open
[screen-orientation] Test exiting fullscreen unlocks the orientation#61537marcoscaceres wants to merge 1 commit into
marcoscaceres wants to merge 1 commit into
Conversation
marcoscaceres
force-pushed
the
screen-orientation-fullscreen-exit
branch
from
July 27, 2026 04:37
ae3da1a to
d4dc956
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds coverage for the Fullscreen and Screen Orientation interaction on the exit path: when a document or a subframe exits fullscreen, the orientation lock is released so the orientation reverts, and a still-pending lock() promise is rejected with AbortError. fullscreen-interactions.html only covers other cases, and the tests skip via assert_implements_optional where orientation locking is unsupported (e.g. desktop).
The abort-on-exit assertion depends on a pending Screen Orientation spec clarification to make the exit-versus-resolve ordering deterministic; the release assertions match the current spec. Context: https://bugs.webkit.org/show_bug.cgi?id=247250