fix: [BREAKING] remove legacy subscription; change subscription interface#394
fix: [BREAKING] remove legacy subscription; change subscription interface#394Rotzbua wants to merge 2 commits intoweb-push-libs:masterfrom
Conversation
|
Hey sorry I plan to review this this weekend, thanks! |
Minishlink
left a comment
Minishlink
left a comment
There was a problem hiding this comment.
Thanks! Sorry for the delay, I'm not sure about the change about null => "" though
| $associativeArray['publicKey'] ?? null, | ||
| $associativeArray['authToken'] ?? null, | ||
| $associativeArray['contentEncoding'] ?? "aesgcm" | ||
| $associativeArray['endpoint'] ?? "", |
There was a problem hiding this comment.
endpoint shouldn't be empty, it should throw before, shouldn't it?
| $associativeArray['authToken'] ?? null, | ||
| $associativeArray['contentEncoding'] ?? "aesgcm" | ||
| $associativeArray['endpoint'] ?? "", | ||
| $associativeArray['keys']['p256dh'] ?? "", |
There was a problem hiding this comment.
I'm not sure this is an improvement, having an empty string instead of null ?
| public function getEndpoint(): string; | ||
|
|
||
| public function getPublicKey(): ?string; | ||
| public function getPublicKey(): string; |
There was a problem hiding this comment.
A subscription can have no public key, auth token or content encoding (sent without any payload)
Remove legacy GCM Remove old Chrome subscription support
[BREAKING] change default encoding to aes128gcm
Rotzbua
force-pushed
the
feat_type_contentencoding
branch
from
e632f72 to
59f2e6e
Compare
| @@ -212,25 +221,25 @@ private static function createContext(string $clientPublicKey, string $serverPub | |||
| * | |||
| * @throws \ErrorException | |||
There was a problem hiding this comment.
Could add @throws \ValueError here?
| protected readonly string $endpoint, | ||
| protected readonly string $publicKey, | ||
| protected readonly string $authToken, | ||
| ContentEncoding|string $contentEncoding = ContentEncoding::aes128gcm, |
| if(is_string($contentEncoding)) { | ||
| try { | ||
| if(empty($contentEncoding)) { | ||
| $this->contentEncoding = ContentEncoding::aesgcm; // default |
There was a problem hiding this comment.
Shouldn't the default be aes128gcm?
|
Hopefully this can be finished & merged soon :) |
|
@Minishlink Just wondering, what's currently missing in that PR? |
|
Yes that's right |
|
I might delay this to v10 and release v9 at the beginning of july. Let me know @Rotzbua if you have time in the near future for this PR, thank you |
|
Hi, Thanks for the amazing repo! |
|
Hello, this library is agnostic about which endpoint is sent by the browser, it only requires compliance with the Web Push standard. |
|
Converted to draft until I have time and back into the php topic. |
|
Thanks for the update! I have one more question: what's the pull request about? Are you planning on supporting the v1 HTTP API too, or is it focused on something else? Looking forward to your response! |
|
@cclegend90 It is just cleanup of obsolete code. The FCM v1 HTTP API (for native apps) is not the Push API (for browser) and not target of this library. |
|
Is there an ETA on when this will be merged/released? |
5 participants
Changes
Breaking:
Feature:
Reference
fixes #381
fixes #345
reference #388