Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves to viewMatrix_GL and related code #32

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Feb 6, 2025

This pull request includes several changes to the WebARKit module, focusing on improving the handling of matrix computations and logging. The most important changes include modifying matrix initialization, adding new methods for matrix computation, and enhancing logging for debugging purposes.

Matrix computation improvements:

  • WebARKit/WebARKitPattern.cpp: Changed the initialization of glViewMatrix to use CV_64FC1 for consistency with pose3d.
  • WebARKit/WebARKitPattern.cpp and WebARKit/include/WebARKitPattern.h: Added a new overloaded method computeGLviewMatrix that accepts a cv::Mat parameter to compute the GL view matrix using a given pose. [1] [2]

Logging enhancements:

Minor changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant