Skip to content

chore: remove unused packages #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: remove unused packages #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d85c1c7
chore: removed unusued dependencies
alcpereira Mar 31, 2025
c38bd74
chore: changeset
alcpereira Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/quick-flowers-shout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"webdriver-image-comparison": patch
"@wdio/visual-reporter": patch
---

Removed unused dependencies
3 changes: 1 addition & 2 deletions packages/visual-reporter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"dependencies": {
"@inquirer/prompts": "^7.3.2",
"ora": "^8.2.0",
"sirv-cli": "^3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alcpereira

It's used here, not sure if you have a better way to do this, but for now I believe this packages still needs to be in the deps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npx should install the package, but I will investigate it a bit further.

In theory npx my-package should download the my-package and also its dependency.
In the code you linked we are calling npx sirv which is for sirv package, but it does not have sirv-cli as a dependency (here).

So it should not have any impact, but I will double check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember sirv is the command and npx is also used to run the server if it's already installed

"sharp": "^0.33.5"
},
"devDependencies": {
Expand Down Expand Up @@ -64,4 +63,4 @@
"engines": {
"node": ">=20.0.0"
}
}
}
4 changes: 1 addition & 3 deletions packages/webdriver-image-comparison/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,12 @@
"watch:js": "node -e \"require('fs').watchFile('src/resemble/resemble.jimp.cjs', () => { require('child_process').exec('npm run copy-js'); });\""
},
"dependencies": {
"fs-extra": "^11.3.0",
"jimp": "^1.6.0",
"@wdio/logger": "^9.4.4"
},
"devDependencies": {
"@types/copyfiles": "~2.4.4",
"@types/fs-extra": "^11.0.4",
"copyfiles": "^2.4.1",
"webdriverio": "^9.9.1"
}
}
}
84 changes: 0 additions & 84 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading