Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(avatar): add WebexAvatar README #18

Merged
merged 1 commit into from
Aug 21, 2019
Merged

docs(avatar): add WebexAvatar README #18

merged 1 commit into from
Aug 21, 2019

Conversation

lalli-flores
Copy link
Contributor

No description provided.

akoushke
akoushke reviewed Aug 20, 2019
View reviewed changes
src/components/WebexAvatar/README.md Outdated

Webex avatar component displays the avatar of a _Webex Teams_ user with a given `personID` and `adapter` object.
![Webex Avatar](./WebexAvatar.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it be nice to center this, but not a blocker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I centered but i don't know if I like it, it's a bit small of an image, so it kinda gets lost

adamweeks
adamweeks reviewed Aug 21, 2019
View reviewed changes
@akoushke
Copy link
Contributor

Our intro README file should be updated accordingly as well. The code is outdated. Also I don’t know if you want to add more info about adapters and data on our intro page in this PR or a separate one.

@lalli-flores
Copy link
Contributor Author

Our intro README file should be updated accordingly as well. The code is outdated. Also I don’t know if you want to add more info about adapters and data on our intro page in this PR or a separate one.

I noticed that too, but I think it should be on a separate PR

@lalli-flores lalli-flores force-pushed the avatar-readme branch 4 times, most recently from aec0b56 to 4f36d57 Compare August 21, 2019 23:07
@akoushke akoushke merged commit 8948c3d into webex:master Aug 21, 2019
@lalli-flores lalli-flores deleted the avatar-readme branch August 21, 2019 23:13
@webex-components-publisher
Copy link
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamweeks adamweeks adamweeks left review comments

@akoushke akoushke akoushke approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lalli-flores @akoushke @webex-components-publisher @adamweeks