-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: Update hint to check for XCTO header on all resources #1842
Breaking: Update hint to check for XCTO header on all resources #1842
Conversation
This reverts changes added to check for this header only on scripts and stylesheets, and instead, checks for the header on all resources. MDN suggests the former, but Chromium uses this response header on more than script/stylesheets for CORB. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Ref webhintio#1221 Close webhintio#1221
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Couple comments in the commit comment for future:
- This should be
Breaking
instead of new because before we were failing if the header was sent to all resources - We should update our examples on how to pass this rule with apache and IIS and update our website's
web.config
- The links at the end should be mostly
Fix #ID
. TheRef
is used to links for further info andClose
to indicate the PR that closes the issue. We should probably update the documentation so it's less confusing
I'm going to request changes but just so we don't forget about updating the documentation for the web servers but otherwise LGTM. If you have time to do it it will be awesome. If not I'll try to do it myself later today.
Thanks!
…x-content-type-options
@molant Added documentation of server config. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I'd love to see us report some of this in the future by examining server configuration files directly when available (filed as #1854).
@molant given the README updates, this touched |
I missed that 😥 |
This reverts changes added to check for this header only on scripts and stylesheets, and instead, checks for the header on all resources. MDN suggests the former, but Chromium uses this response header on more than script/stylesheets for CORB. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix #1221 Close #1842
OK, should be fixed now. Nice catch @antross |
This reverts changes added to check for this header only
on scripts and stylesheets, and instead, checks for the header
on all resources. MDN suggests the former, but Chromium uses
this response header on more than script/stylesheets for
CORB.
Ref #1221
Close #1221
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also: