Fix errors reported by the online scanner

[chipitsine]

https://sonarwhal.com/scanner/a33d0a1f-8219-418b-b595-f38c91a1709a

it's a report for your own site. it is not perfect.
looks like you do not use your own tools

[molant]

I was aware of the Vary errors and the issues with the SW file (#362), but not the ones about the favicon.
We are compressing them using zopfli and brotli so I imagine this is something related to the web.config file?

Thanks!

[chipitsine]

well, good UX pattern is so called "call for action".
e.g. "here's the issue ... and here is what we want you to do: ..."

I think your tool would do its best if it would advice what to do. not "is it somewhat related to web.config ?", but "here's what you can do with your web.config"

such a way would be more helpful to users.

[molant]

I think your tool would do its best if it would advice what to do. not "is it somewhat related to web.config ?"

This was a comment to know where to start looking for the person that will take this issue. I'm almost sure it's a problem in our web.config file.

but "here's what you can do with your web.config"

I agree, and that's what we do with some of the rules already as we announced in this blogpost 😊

[molant]

Current errors and status:

• Vary header has incorrect content. Should be Accept-Encoding and not Content-Encoding. This was also a problem in the documentation (webhintio/hint@5825dea, 9c8a1a3)
• favico is not server compressed, it comes compressed don't know why it was failing
• sw cache

Latest scan: https://sonarwhal.com/scanner/f8c35810-b101-4889-97a4-25472a1885f1

[molant]

Closing this in favor of #434 that has the latest results.