-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sonarwhal scanner reports 35 errors on https://sonarwhal.com/scanner #434
Comments
@clslgrnc thanks! There are a few that I was already aware of (cloudflare errors) but some others I'm surprised (web.manifest for example). |
To do so, I'm moving some files from the cdn to our server. This commit also calculate sri for the scanner resources ref webhintio#434
* Move 3rd party dependencies locally * Add `cache-control` where missing * Add `.eslintrc` file for web JS files - - - - - - - - - - - - - - - - - - - - - - - - - - Ref #434
To do so, I'm moving some files from the cdn to our server. This commit also calculate sri for the scanner resources ref webhintio#434
The new results are in https://sonarwhal.com/scanner/bd5bd893-fb87-4c63-a63d-ea3987d98d7c (8 errors) There's something weird going on with the manifest because sonarwhal reports no compression and no caching when it's not true. If we access https://sonarwhal.com/static/site-b1a71cb190.webmanifest with the dev tools open I can see Also not sure why the cache busting isn't picked up, it uses the same pattern as the other files so we will have to investigate. |
Latest scan results: https://webhint.io/scanner/b6fa3d1f-81f1-4117-859c-49bfc3ba2ecc There's one error with the |
* Rev `.webmanifest` * Add missing `favicon.ico` to regular pages - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix webhintio#434
* Rev `.webmanifest` * Add missing `favicon.ico` to regular pages * Disable default ASP session state cookie - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix webhintio#434
As already mentioned in #400, your tool finds a few issues on your website:
https://sonarwhal.com/scanner/6d4b238b-d596-40fb-a366-ddbf31069612
Moreover, your pull request template has two dead links and a typo:
The text was updated successfully, but these errors were encountered: