Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonarwhal scanner reports 35 errors on https://sonarwhal.com/scanner #434

Closed
clslgrnc opened this issue May 6, 2018 · 3 comments
Closed
Assignees

Comments

@clslgrnc
Copy link
Contributor

clslgrnc commented May 6, 2018

As already mentioned in #400, your tool finds a few issues on your website:
https://sonarwhal.com/scanner/6d4b238b-d596-40fb-a366-ddbf31069612

Moreover, your pull request template has two dead links and a typo:

@molant
Copy link
Member

molant commented May 7, 2018

@clslgrnc thanks!

There are a few that I was already aware of (cloudflare errors) but some others I'm surprised (web.manifest for example).

sarvaje added a commit to sarvaje/webhint.io that referenced this issue May 7, 2018
To do so, I'm moving some files from the cdn to our server.
This commit also calculate sri for the scanner resources

ref webhintio#434
molant pushed a commit that referenced this issue May 8, 2018
* Move 3rd party dependencies locally
* Add `cache-control` where missing
* Add `.eslintrc` file for web JS files

- - - - - - - - - - - - - - - - - - - - - - - - - -

Ref #434
sarvaje added a commit to sarvaje/webhint.io that referenced this issue May 8, 2018
To do so, I'm moving some files from the cdn to our server.
This commit also calculate sri for the scanner resources

ref webhintio#434
@molant
Copy link
Member

molant commented May 9, 2018

The new results are in https://sonarwhal.com/scanner/bd5bd893-fb87-4c63-a63d-ea3987d98d7c (8 errors)

There's something weird going on with the manifest because sonarwhal reports no compression and no caching when it's not true. If we access https://sonarwhal.com/static/site-b1a71cb190.webmanifest with the dev tools open I can see br compression. Maybe an issue with the jsdom connector?

Also not sure why the cache busting isn't picked up, it uses the same pattern as the other files so we will have to investigate.

@molant
Copy link
Member

molant commented Aug 20, 2018

Latest scan results: https://webhint.io/scanner/b6fa3d1f-81f1-4117-859c-49bfc3ba2ecc

There's one error with the web.manifest (again...).

molant added a commit to molant/webhint.io that referenced this issue Aug 23, 2018
molant added a commit to molant/webhint.io that referenced this issue Aug 23, 2018
* Rev `.webmanifest`
* Add missing `favicon.ico` to regular pages

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#434
molant added a commit to molant/webhint.io that referenced this issue Aug 23, 2018
* Rev `.webmanifest`
* Add missing `favicon.ico` to regular pages
* Disable default ASP session state cookie

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio#434
@alrra alrra closed this as completed in 964a280 Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants