Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Reduce sonarwhal scan erros in sonarwhal.com/scanner #437

Merged
merged 3 commits into from
May 8, 2018

Conversation

sarvaje
Copy link
Contributor

@sarvaje sarvaje commented May 7, 2018

To do so, I'm moving some files from the cdn to our server.
This commit also calculate sri for the scanner resources

ref #434

Pull request checklist

Make sure you:

Short description of the change(s)

To do so, I'm moving some files from the cdn to our server.
This commit also calculate sri for the scanner resources

ref webhintio#434
@sarvaje sarvaje changed the title Fix: Reduce sonarwhal erros in sonarwhal.com/scanner Fix: Reduce sonarwhal scan erros in sonarwhal.com/scanner May 7, 2018
Copy link
Member

@molant molant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a .eslintrc adapting the rules for web development in src/sonarwhal-theme/source/js/ so the errors in CI get fixed?

@sarvaje sarvaje force-pushed the scanner-scanner branch from dcaf7c2 to 7e38c36 Compare May 8, 2018 19:09
@molant molant merged commit 461dae1 into webhintio:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants