Skip to content

Fix: Reduce sonarwhal scan erros in sonarwhal.com/scanner #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 39 additions & 4 deletions gulpfile.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
const path = require('path');
const fs = require('fs');

const gulp = require('gulp');
const plugins = require('gulp-load-plugins')();
const pump = require('pump');
Expand Down Expand Up @@ -247,10 +250,41 @@ gulp.task('generate-service-worker', (callback) => {
}, callback);
});

const transform = (jsonResult) => {
const result = {};
const entries = Object.entries(jsonResult);

for (const [key, value] of entries) {
result[key.replace(`${dirs.tmp}/source`, '')] = value;
}

return result;
};

gulp.task('sri', () => {
return gulp.src(`${dirs.dist}/**/*.html`)
.pipe(plugins.sriHash())
.pipe(gulp.dest(dirs.dist));
return gulp.src(`${dirs.tmp}/source/**/*.{js,css}`)
.pipe(plugins.sri({ algorithms: ['sha384'], transform }))
.pipe(gulp.dest(dirs.tmp));
});

let sriList;

const replaceSRI = (content) => {
let result = content;

for (const [file, value] of Object.entries(sriList)) {
result = result.replace(`${file}"`, `${file}" integrity="${value}" crossorigin="anonymous"`);
}

return result;
};

gulp.task('add-sri', () => {
sriList = JSON.parse(fs.readFileSync(path.join(__dirname, dirs.tmp, 'sri.json'), 'utf8')); //eslint-disable-line no-sync

return gulp.src(`${dirs.tmp}/**/*.hbs`)
.pipe(plugins.transform('utf8', replaceSRI))
.pipe(gulp.dest(dirs.tmp));
});

gulp.task('build', gulp.series(
Expand All @@ -267,9 +301,10 @@ gulp.task('build', gulp.series(
'revfiles',
'revreplace:content',
'revreplace:theme',
'sri',
'add-sri',
'build:hexo',
'generate-service-worker',
'sri',
'compress:zopfli',
'compress:brotli'
));
Expand Down
2 changes: 1 addition & 1 deletion helpers/update-content.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const categories = {};

const processRule = (rule, isSummary) => {
const processedRule = {
/*
/*
* For packages with multiple rules we have a summary
* file with how to install and links to all the rules.
* This property is used to not take into account in
Expand Down
Loading