Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider delete staging during build. #783

Closed
sarvaje opened this issue Aug 14, 2019 · 1 comment · Fixed by #835
Closed

Consider delete staging during build. #783

sarvaje opened this issue Aug 14, 2019 · 1 comment · Fixed by #835
Assignees
@molant
Labels
priority: medium
Milestone
1909-2

Comments

@sarvaje
Copy link
Contributor

sarvaje commented Aug 14, 2019

Yesterday (08/14/2019) we have a problem in staging that was resolve only after delete all the files from staging.

If this happens again, we should consider (if it is possible) force a deletion of the existing content in staging before deploy.
@antross
Copy link
Member

antross commented Aug 14, 2019

Chatting with @hxlnt, she suggested this may have been due to stale state in the node_modules folder. Even though we were updating package-lock.json, npm may have already had some empty folders for certain packages due to the previously corrupted state that it wasn't updating until they got deleted.

Regardless, still a good thing to consider the delete step - especially if we see this again.

@molant molant self-assigned this Sep 20, 2019
@molant molant added this to the 1909-2 milestone Sep 20, 2019
molant added a commit to molant/webhint.io that referenced this issue Sep 20, 2019
@molant
Build: Clean up workspace on deploy
ba962d7 
Fix webhintio#783
@molant molant mentioned this issue Sep 20, 2019
Merged
2 tasks
molant added a commit to molant/webhint.io that referenced this issue Sep 20, 2019
@molant
Build: Clean up workspace on deploy
ff08781 
Fix webhintio#783
molant added a commit that referenced this issue Sep 25, 2019
@molant
Build: Deployment improvements
fc399d4 
* Clean up workspace on deploy
* Stop release if issues are find during deployment

- - - - - - - - - - - - - - - - - - - - - - -

Fix #783
Fix #717
Close #835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@molant molant

Labels
priority: medium
Projects
None yet
Milestone
1909-2
Development

Successfully merging a pull request may close this issue.

Build: Clean up workspace on deploy molant/webhint.io
3 participants
@molant @antross @sarvaje