Build: Clean up workspace on deploy #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This should be ready for a review. |
antross
approved these changes
Sep 24, 2019
molant
commented
Sep 24, 2019
| @@ -7,14 +7,10 @@ | |||
| "express": "^4.17.1", | |||
| "globby": "^10.0.1", | |||
| "highlight.js": "^9.15.10", | |||
| "hint": "^5.2.3", | |||
There was a problem hiding this comment.
Need to install hint somewhere to test staging or we could use npx hint https://staging
sarvaje
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
Short description of the change(s)
Deletes
node_modulesandpackage-lock.jsonbefore runningnpm install --productionon the deployment server.Even though it has
package-lock=falsewe need to remove the previous version.I've tested this on
sonarwhal-tests.azurewebsites.netand folders and files are deleted so it should be safe to merge.Fix #783