Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] HTML Formatter not removing categories without hints? #869

Closed
molant opened this issue Sep 12, 2019 · 4 comments · Fixed by #870
Closed

[Bug] HTML Formatter not removing categories without hints? #869

molant opened this issue Sep 12, 2019 · 4 comments · Fixed by #870
Assignees

Comments

@molant
Copy link
Member

molant commented Sep 12, 2019

When doing a scan on the online scanner I get the following:

image

https://webhint.io/scanner/cf35c25d-b58a-4d53-ae15-41588bb1ecd2#category-Pitfalls

I don't see any hint active for the pitfall category in the configuration so I would expect the formatter to automatically hide categories that do not have any hint active.

@antross
Copy link
Member

antross commented Sep 12, 2019

Also seems we should have some hints active in the online scanner in this category. Think we could sort out some way to have this align with configuration-web-recommended automatically in the future?

@molant
Copy link
Member Author

molant commented Sep 12, 2019

@sarvaje, aren't we extending from that config already?
Maybe the problem is that we haven't updated production in a while?

@sarvaje
Copy link
Contributor

sarvaje commented Sep 12, 2019

the online scanner is not extending configuration-web-recommended. The extends property is not supported in production yet.

@sarvaje sarvaje self-assigned this Dec 4, 2019
@sarvaje
Copy link
Contributor

sarvaje commented Dec 4, 2019

I'm going to move this issue to the webhint.io repository, this issue only happens in the website.

@sarvaje sarvaje transferred this issue from webhintio/hint Dec 4, 2019
sarvaje added a commit to sarvaje/webhint.io that referenced this issue Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants