Fix: Support mapping links to full URLs from hint Github repo
#934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molant
reviewed
Aug 14, 2020
helpers/update-site/documentation.js
Outdated
| * In this case we need to replace it with the a valid | ||
| * url in the website. | ||
| */ | ||
| if (val[2].startsWith('https')) { |
There was a problem hiding this comment.
It is a bit weird to say the link is for github and then check just for https.
Suggested change
| if (val[2].startsWith('https')) { | |
| if (val[2].startsWith('https://github.com/')) { |
helpers/update-site/documentation.js
Outdated
| if (val[2].startsWith('https')) { | ||
| replacement = | ||
| `${val[1]}/docs/${file.frontMatter.section}${file.frontMatter.tocTitle ? `/${file.frontMatter.tocTitle.replace(' ', '-')}` : ''}/${val[4].replace('/docs/', '/')}/`; | ||
|
|
There was a problem hiding this comment.
Maybe we could document what the different val[x] are?
|
@molant I have addressed all your feedback. I also fix an edge case, when the package is the |
|
@molant any additional feedback or is this good to merge? |
molant
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #933
Pull request checklist
Make sure you:
Short description of the change(s)