Fix: Changelog #800
Fix: Changelog #800
Conversation
helpers/update-site/documentation.js
Outdated
| @@ -724,7 +724,7 @@ const createHintCategories = (files) => { | |||
| }; | |||
|
|
|||
| const updateChangelog = async () => { | |||
| const files = await globby([`${constants.dirs.HINT_PACKAGES}/*/CHANGELOG.md`]); | |||
| const files = await globby([`${constants.dirs.NODE_MODULES}/{hint,@hint/{${resources.join(',')},configuration-*/node_modules/@hint/{${resources.join(',')}}}-*}/CHANGELOG.md`]); | |||
There was a problem hiding this comment.
Probably applies elsewhere in this file, but shouldn't all resources be under either the root node_modules or under node_modules/configuration-all/node_modules? In other words, do we need to search all configurations?
On a related note, is there any reason we're excluding configurations themselves by limiting this to @hint/{connector-*, extension-*, formatter-*, hint-*, parser-*} versus grabbing all @hint/* packages (also probably applies elsewhere in this file)?
There was a problem hiding this comment.
I think we weren't including configuration to the documentation, but I think we should include it.
There was a problem hiding this comment.
versus grabbing all @hint/*
I think we don't want to grab @hint/utils*.
There was a problem hiding this comment.
Good point. Though perhaps we should just be getting the list from configuration-all? That should already be excluding the packages we don't want. Then we're not duplicating the filtering logic here.
There was a problem hiding this comment.
yep, I'm working on the configuration-all thing.
sarvaje
force-pushed
the
fix-changelog
branch
from
94fbdf7 to
89c5fec
Compare
Fix #799
Pull request checklist
Make sure you:
Short description of the change(s)