Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes "Signal issue" from docs #966

Merged
merged 3 commits into from
May 10, 2021
Merged

Removes "Signal issue" from docs #966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea93e8c
Update doc.ejs
hxlnt May 7, 2021
9b9b8f1
Removes getSignalIssueQuery
hxlnt May 7, 2021
96e54e4
Update utils.js
hxlnt May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/webhint-theme/helper/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
const pagination = require('./pagination');

const url = require('url');

const isIndexPage = (page) => {
return page.source.endsWith('index.md');
};
Expand Down Expand Up @@ -77,12 +75,6 @@ module.exports = {
return page.section === section;
});
},
getSignalIssueQuery: (root, title, directory) => {
const issueTitle = `[docs] Issue with '${title}'`;
const issueContent = url.resolve(root, directory);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, we're failing CI because linting is now complaining that url is no longer used (as this was the only usage). If you remove the definition from the top of the file that should take care of it.

const url = require('url');

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch--fixed!


return `title=${encodeURIComponent(issueTitle)}&body=${encodeURIComponent(issueContent)}`;
},
/**
* Return the `href` value to link to the target page from the current one.
* for example when the current page is `hint-amp-validator`:
Expand Down
7 changes: 0 additions & 7 deletions src/webhint-theme/layout/partials/doc.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,6 @@ toCItems = utils.getToCItems(pages); %>
>Edit</a
>
</li>
<li>
<a
target="_blank"
href="<%= `${theme.webhintRepoRoot}/issues/new?${utils.getSignalIssueQuery(theme.webhintRoot, page.title, page.permalink)}` %>"
>Signal Issue</a
>
</li>
</ul>
</div>
</header>
Expand Down