Conversation
|
Kindly provide detailed information about the PR to make it easier for the maintainers to follow. Shallow PRs are difficult to review and get through. If not, this PR will be closed and marked as spam. |
|
I probably wouldn't classify this as spam @detox-24, It looks like there's a legitimate PR. However, @black-desk I would like to see documentation in the README. If you get that in, I will review the PR and get it in this week. (I'm back after a long hiatus due to being burnt out form the spam) |
|
@coolaj86 Yes, the contribution was legit. But providing appropriate docs should be mandatory, no? So that maintainers get a rough idea on workflow and don't waste time on figuring out. |
I might update the documentation in the next few days. Sorry, I've been a bit busy lately. |
There was a problem hiding this comment.
1.) README.md could include their official feature tutorial link on youtube.
https://www.youtube.com/watch?v=CPLdltN7wgE
Oops! Running the windows installer now returns 'can't recognize OsPlatform'.
os.platform() returns win32.
I'm seeing this issue in different kinds now, I think its about time 'os' package is examined and its output cases are documented. See #1044.
And @black-desk, I'm sorry about the regex thing earlier, it was merely a path formatting issue in powershell. :)
Note: The installer is tried and tested on Linux machine, and behaves as expected.
Signed-off-by: Chen Linxuan <me@black-desk.cn>
No description provided.