Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve abacard design #5314

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Improve abacard design #5314

merged 2 commits into from
Jan 30, 2025

Conversation

falbru
Copy link
Contributor

@falbru falbru commented Jan 29, 2025

Description

Add color code and icons to the scan result

Result

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.

Description Before After
På venteliste
Registrert

Testing

  • I have thoroughly tested my changes.

I've tested all the new error codes, and they work


Resolves ABA-1235

@falbru falbru added the enhancement Pull requests that make enhancements, instead of just purely new features label Jan 29, 2025
Copy link

linear bot commented Jan 29, 2025

@falbru falbru added the review-needed Pull requests that need review label Jan 29, 2025
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 11:36am

@falbru falbru requested a review from a team January 29, 2025 21:09
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! Could use a little cleaning and then we're good to go

app/routes/bdb/components/BdbDetail.tsx Outdated Show resolved Hide resolved
app/components/UserValidator/index.tsx Outdated Show resolved Hide resolved
app/components/UserValidator/index.tsx Show resolved Hide resolved
app/components/UserValidator/index.tsx Outdated Show resolved Hide resolved
@falbru falbru force-pushed the improve-abacard-design branch from fc36d5c to 7fe2ef7 Compare January 29, 2025 21:31
@falbru falbru requested a review from norbye January 29, 2025 21:31
@falbru falbru force-pushed the improve-abacard-design branch from 7fe2ef7 to cec4e1e Compare January 29, 2025 21:35
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

app/components/UserValidator/index.tsx Outdated Show resolved Hide resolved
@falbru falbru force-pushed the improve-abacard-design branch from cec4e1e to 6c60dd0 Compare January 29, 2025 21:40
Copy link
Contributor

@Bestem0r Bestem0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@norbye
Copy link
Member

norbye commented Jan 30, 2025

Apologies for steal, but I want, I need, I deploy 🚀

@norbye norbye merged commit b6c4179 into master Jan 30, 2025
8 checks passed
@norbye norbye deleted the improve-abacard-design branch January 30, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants