Add too many tokens errors and token-counting APIs #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added a commit
to webmachinelearning/prompt-api
that referenced
this pull request
Jan 23, 2025
This is mostly to align with webmachinelearning/writing-assistance-apis#31: * Use TooManyTokensError when appropriate, instead of a "QuotaExceededError" DOMException. * Rename tokensLeft/tokensSoFar to tokensAvailable/tokenCount. * Rename countPromptTokens() to countTokens(). * Remove maxTokens. * Rename "contextoverflow" to "overflow", since the vocabulary "context" is not used elsewhere in the API and there's only one relevant type of overflow for the session.
|
|
||
| It's possible that the inputs given for summarizing and rewriting might be too large for the underlying machine learning model to handle. The same can even be the case for strings that are usually smaller, such as the writing task for the writer API, or the context given to all APIs. | ||
|
|
||
| Whenever any API call fails due to too-large input, it is rejected with a `TooManyTokensError`. This is a new type of exception, which subclasses `DOMException`, and has the following additional properties: |
There was a problem hiding this comment.
Would it make sense to generalize the terminology here for other situations where input size could exceed a limit?
There was a problem hiding this comment.
Yes, that's probably a good idea. That might change my take on the naming for tokensAvailable to follow that new model, hmm. Like if we choose quota for the property of the exception, then maybe it should be tokenQuota.
I posted whatwg/webidl#1463.
There was a problem hiding this comment.
Proposed better idea at whatwg/webidl#1465 . This PR is on hold until we have agreement on that front.
domenic
force-pushed
the
too-large-input
branch
from
9211561 to
70d6311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5.
Preview | Diff