Add support for specifiedBy directive #1616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
reviewed
Oct 17, 2024
| @@ -414,7 +414,8 @@ protected function p(?Node $node): string | |||
| return BlockString::print($node->value); | |||
| } | |||
|
|
|||
| return \json_encode($node->value, JSON_THROW_ON_ERROR); | |||
| // Do not escape unicode or slashes in order to keep urls valid | |||
There was a problem hiding this comment.
Suggested change
| // Do not escape unicode or slashes in order to keep urls valid | |
| // Do not escape unicode or slashes in order to keep URLs valid |
Comment on lines
26
to
+31
| public const IF_ARGUMENT_NAME = 'if'; | ||
| public const SKIP_NAME = 'skip'; | ||
| public const DEPRECATED_NAME = 'deprecated'; | ||
| public const SPECIFIED_BY_NAME = 'specifiedBy'; | ||
| public const REASON_ARGUMENT_NAME = 'reason'; | ||
| public const URL_ARGUMENT_NAME = 'url'; |
There was a problem hiding this comment.
Suggested change
| public const IF_ARGUMENT_NAME = 'if'; | |
| public const SKIP_NAME = 'skip'; | |
| public const DEPRECATED_NAME = 'deprecated'; | |
| public const SPECIFIED_BY_NAME = 'specifiedBy'; | |
| public const REASON_ARGUMENT_NAME = 'reason'; | |
| public const URL_ARGUMENT_NAME = 'url'; | |
| public const SKIP_NAME = 'skip'; | |
| public const IF_ARGUMENT_NAME = 'if'; | |
| public const DEPRECATED_NAME = 'deprecated'; | |
| public const REASON_ARGUMENT_NAME = 'reason'; | |
| public const SPECIFIED_BY_NAME = 'specifiedBy'; | |
| public const URL_ARGUMENT_NAME = 'url'; |
Comment on lines
+408
to
+409
| * Given a collection of directives, returns the string value for the | ||
| * specifiedBy url. |
There was a problem hiding this comment.
Suggested change
| * Given a collection of directives, returns the string value for the | |
| * specifiedBy url. | |
| * Given a collection of directives, returns the string value for the specifiedBy URL. |
| @@ -318,7 +318,7 @@ public function testWSLWithWellPlacedDirectives(): void | |||
|
|
|||
| extend type MyObj @onObject | |||
|
|
|||
| scalar MyScalar @onScalar | |||
| scalar MyScalar @onScalar | |||
There was a problem hiding this comment.
Suggested change
| scalar MyScalar @onScalar | |
| scalar MyScalar @onScalar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I just added support for the @specifiedBy directive, because it is still missing and I need the support, because otherwise the validation of https://github.com/spawnia/sailor fails and blocks me.
Can you please take a review?
Todos left
I was not able to fix SchemaExtenderTest.testExtendsScalarsByAddingSpecifiedByDirective during my timeframe :/
Can you support here please?
Thanks a lot,
Kay