Skip to content

Allow extending SchemaPrinter by making its methods protected #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2020
Merged

Allow extending SchemaPrinter by making its methods protected #671

merged 1 commit into from
Jun 19, 2020

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Jun 11, 2020

This opens up a much needed escape hatch for experimental features
such as Apollo Federation, see #552

@spawnia
Allow extending SchemaPrinter by making its methods protected
bf4ec02 
This opens up a much needed escape hatch for experimental features
such as Apollo Federation, see #552
@spawnia spawnia requested a review from vladar June 11, 2020 20:21
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.148% when pulling bf4ec02 on unprivatize-schema-printer into a747575 on master.

vladar
vladar approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@vladar vladar merged commit 3fd08eb into master Jun 19, 2020
@spawnia spawnia deleted the unprivatize-schema-printer branch July 3, 2020 08:52
@kurzyx kurzyx mentioned this pull request Oct 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spawnia @coveralls @vladar