-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve extendability of validator rules #854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love opening up the things, aligns with my philosophy.
I guess however it's important to keep in mind that only @api
marked elements are covered by semver/backwards compatibility promises.
(I kind of made this up from observation on this repository, could not quickly find a proper doc if this is the case -> all my search for @api
only yielded code-use)
There is more work to be done with those classes in regards to strict typing. At least the properties are done now and the member visibility is fine, so this is a good point to merge as is. |
Resolves #851