Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve extendability of validator rules #854

Merged
merged 8 commits into from
Apr 28, 2021
Merged

Improve extendability of validator rules #854

merged 8 commits into from
Apr 28, 2021

Conversation

wimski
Copy link
Contributor

@wimski wimski commented Apr 26, 2021

Resolves #851

Yes. Accepting PRs, but preferrably one that opens up all validation rules for extensibility to ensure consistency.

Copy link
Contributor

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love opening up the things, aligns with my philosophy.

I guess however it's important to keep in mind that only @api marked elements are covered by semver/backwards compatibility promises.
(I kind of made this up from observation on this repository, could not quickly find a proper doc if this is the case -> all my search for @api only yielded code-use)

@spawnia
Copy link
Collaborator

spawnia commented Apr 28, 2021

There is more work to be done with those classes in regards to strict typing. At least the properties are done now and the member visibility is fine, so this is a good point to merge as is.

@spawnia spawnia merged commit 0d43d7b into webonyx:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove static from GraphQL\Validator\Rules\ValuesOfCorrectType
5 participants