-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add type definitions #88
Open
harish-sethuraman
wants to merge
2
commits into
webpack-contrib:master
Choose a base branch
from
harish-sethuraman:try-adding-typedef
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{ | ||
"compilerOptions": { | ||
"target": "esnext", | ||
"moduleResolution": "node", | ||
"allowJs": true, | ||
"checkJs": true, | ||
"strict": true, | ||
"types": ["node"], | ||
"resolveJsonModule": true, | ||
"newLine": "LF", | ||
"allowSyntheticDefaultImports": true | ||
}, | ||
"include": ["./src/**/*"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
declare const _exports: typeof loader.default; | ||
export = _exports; | ||
import loader = require("./index"); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/** @typedef {import("source-map").RawSourceMap} RawSourceMap */ | ||
/** @typedef {import("schema-utils/declarations/validate").Schema} Schema */ | ||
/** | ||
* @template T | ||
* @typedef {Object} LoaderOptions<T>Allows to choose how errors are displayed. | ||
* @property {"commonjs" | "module"} [type] | ||
* @property {string| object | string[] | object[]} exports | ||
*/ | ||
/** | ||
* The exports loader allows to setup exports | ||
* @template T | ||
* @this {import("webpack").LoaderContext<LoaderOptions<T>>} | ||
* @param {string} content | ||
* @param { RawSourceMap } sourceMap | ||
*/ | ||
export default function loader<T>( | ||
this: import("webpack").LoaderContext<LoaderOptions<T>>, | ||
content: string, | ||
sourceMap: RawSourceMap | ||
): void; | ||
export type RawSourceMap = import("source-map").RawSourceMap; | ||
export type Schema = import("schema-utils/declarations/validate").Schema; | ||
/** | ||
* <T>Allows to choose how errors are displayed. | ||
*/ | ||
export type LoaderOptions<T> = { | ||
type?: "module" | "commonjs" | undefined; | ||
exports: string | object | string[] | object[]; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
export type RawSourceMap = import("source-map").RawSourceMap; | ||
/** | ||
* <T> | ||
*/ | ||
export type LoaderOptions<T> = { | ||
type?: string | undefined; | ||
exports?: string | object | string[] | object[] | undefined; | ||
}; | ||
/** | ||
* The exports loader allows to setup exports | ||
*/ | ||
export type LoaderOption<T> = import("webpack").LoaderContext<LoaderOptions<T>>; | ||
export type Identifier = { | ||
type: string; | ||
value?: string | undefined; | ||
}; | ||
export type Export = { | ||
syntax: string; | ||
name?: string | undefined; | ||
alias?: string | undefined; | ||
}; | ||
/** | ||
* | ||
* @param {string} type | ||
* @param {string| object | string[] | object[]} exports | ||
* @returns | ||
*/ | ||
export function getExports( | ||
type: string, | ||
exports: string | object | string[] | object[] | ||
): Export[]; | ||
/** | ||
* @template T | ||
* @param {LoaderOption<T>} loaderContext | ||
* @param {"commonjs"|"module"} type | ||
* @param {Array<Export>} exports | ||
* @returns | ||
*/ | ||
export function renderExports<T>( | ||
loaderContext: import("webpack").LoaderContext<LoaderOptions<T>>, | ||
type: "commonjs" | "module", | ||
exports: Array<Export> | ||
): string; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the
callback(null, ${content}\n${FOOTER}${exportsCode}, sourceMap);
takes type defSourceMap
that is not exported from webpack. Should we export that and consume it here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, it is interface with the same methods...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in webpack
This is in source-map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should investigate it, maybe add better types, because ignore is not good idea for types, looks like problem in
version
, we can improve itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which version are you mentioning? webpack? It is in its latest version. I hope the
source-map
is in latest version as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we export the SourceMap from webpack and consume it? Is it not recommended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think webpack have own types for source maps due to this we have problems with types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump