fix: webpack compilations fail when using filesystem cache, #458

webpack-contrib · Dec 16, 2024 · b6fbf39 · b6fbf39
1 parent 8eb07f8
commit b6fbf39
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/loader.js b/src/loader.js
@@ -204,10 +204,12 @@ async function loader(content) {
   }
 
   let isAbsolute = isAbsoluteURL(this.resourcePath);
+  const isData = this.resourcePath.startsWith("DATA:");
+  const shouldMakeRelative = !isData && isAbsolute;
 
-  const filename = isAbsolute
-    ? this.resourcePath
-    : path.relative(this.rootContext, this.resourcePath);
+  const filename = shouldMakeRelative
+    ? path.relative(this.rootContext, this.resourcePath)
+    : this.resourcePath;
 
   const minifyOptions =
     /** @type {import("./index").InternalWorkerOptions<T>} */ ({

diff --git a/test/ImageminPlugin.test.js b/test/ImageminPlugin.test.js
@@ -919,7 +919,7 @@ describe("imagemin plugin", () => {
     const stringStats = stats.toString({ relatedAssets: true });
 
     expect(stringStats).toMatch(
-      /asset loader-test.webp.+\[from: .+loader-test.png\] \[generated\]/,
+      /asset loader-test.webp.+\[from: .*loader-test.png\] \[generated\]/,
     );
   });
 
@@ -1386,7 +1386,7 @@ describe("imagemin plugin", () => {
     expect(warnings).toHaveLength(0);
     expect(errors).toHaveLength(1);
     expect(errors[0].message).toMatch(
-      /Multiple values for the 'encodeOptions' option is not supported for '.+loader-test.png', specify only one codec for the generator/,
+      /Multiple values for the 'encodeOptions' option is not supported for '.*loader-test.png', specify only one codec for the generator/,
     );
   });
 
@@ -1771,7 +1771,7 @@ describe("imagemin plugin", () => {
     expect(warnings).toHaveLength(0);
     expect(errors).toHaveLength(1);
     expect(errors[0].message).toMatch(
-      /Error with '.+loader-test.txt': Input file has an unsupported format/g,
+      /Error with '.*loader-test.txt': Input file has an unsupported format/g,
     );
   });