Skip to content

Commit

Permalink
Always download PDF + non HTML page cleanup + enterprise policy clean…
Browse files Browse the repository at this point in the history
…up (#629)

Adds enterprise policy to always download PDF and sets download dir to
/dev/null
Moves policies to chromium.json and brave.json for clarity
Further cleanup of non-HTML loading path:
- sets downloadResponse when page load is aborted but response is
actually download
- sets firstResponse when first response finishes, but page doesn't
fully load
 - logs that non-HTML pages skip all post-crawl behaviors in one place
 - move page extra delay to separate awaitPageExtraDelay() function, applied for all pages (while post-load delay only applied to HTML pages)

---------
Co-authored-by: Tessa Walsh <[email protected]>
  • Loading branch information
ikreymer authored Jun 26, 2024
1 parent 6a9ca3d commit 4495532
Show file tree
Hide file tree
Showing 8 changed files with 393 additions and 234 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"BraveRewardsDisabled": true,
"BraveWalletDisabled": true,
"BraveVPNDisabled": 1,
"BraveAIChatEnabled": false
"BraveAIChatEnabled": false,
"TorDisabled": true
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
{
"AlwaysOpenPdfExternally": true,
"NewTabPageLocation": "about:blank",
"RestoreOnStartup": 5,
"IncognitoModeAvailability": 1,
"TorDisabled": true,
"AllowFileSelectionDialogs": false,
"URLBlocklist": [
"file://*"
]
],
"DownloadDirectory": "/dev/null"
}
Loading

0 comments on commit 4495532

Please sign in to comment.