don't exclude 204s

webrecorder · Jan 17, 2024 · ea9639f · ea9639f
1 parent bc201be
commit ea9639f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/util/recorder.ts b/src/util/recorder.ts
@@ -912,7 +912,7 @@ export class Recorder {
   }
 
   async serializeToWARC(reqresp: RequestResponseInfo) {
-    if (reqresp.shouldSkip()) {
+    if (reqresp.shouldSkipSave()) {
       const { url, method, status, payload } = reqresp;
       logNetwork("Skipping request/response", {
         url,

diff --git a/src/util/reqresp.ts b/src/util/reqresp.ts
@@ -270,12 +270,12 @@ export class RequestResponseInfo {
     return true;
   }
 
-  shouldSkip() {
-    // skip OPTIONS/HEAD responses, and 304, 204 or 206 responses
+  shouldSkipSave() {
+    // skip OPTIONS/HEAD responses, and 304 or 206 responses
     if (
       !this.payload ||
       (this.method && ["OPTIONS", "HEAD"].includes(this.method)) ||
-      [204, 206, 304].includes(this.status)
+      [206, 304].includes(this.status)
     ) {
       return true;
     }