Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry support and additional fixes #743

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Retry support and additional fixes #743

wants to merge 6 commits into from
+134 −39

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Jan 18, 2025 •
edited
Loading

  • retries: for failed pages, set retry to 5 in cases multiple retries may be needed.
  • redirect: if page url is /path/ -> /path, don't add as extra seed
  • proxy: don't use global dispatcher, pass dispatcher explicitly when using proxy, as proxy may interfere with local network requests
  • final exit flag: if crawl is done and also interrupted, ensure WACZ is still written/uploaded by setting final exit to true

todo:

  • remove hack to enable autoclick with adblocking (needed until browsertrix 1.14 release)

@ikreymer
set failed URL retry to 5 by default
5961a52
@ikreymer
additional fixes:
7b5ba97 
- redirect: if page url is /path/ -> /path, don't add as extra seed
- proxy: don't use global dispatcher, pass dispatcher explicitly when using proxy
@ikreymer
ensure 'finalExit' is set if crawl is fully done!
3539755
@ikreymer ikreymer requested a review from tw4l January 18, 2025 10:37
@ikreymer ikreymer mentioned this pull request Jan 21, 2025
Closed
@ikreymer ikreymer changed the title Additional fixes Retry support and additional fixes Jan 21, 2025
@ikreymer
retries: move page urls that failed after all retries to separate :ff…
688cb5e 
… list

tests: add test for retry, ensure all retries are used
tw4l
tw4l reviewed Jan 21, 2025
View reviewed changes
src/util/argParser.ts
Comment on lines +703 to +705
if (argv.blockAds) {
argv.behaviors.push("autoclick");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a comment so we remember to undo this

@ikreymer ikreymer marked this pull request as ready for review January 21, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikreymer @tw4l