exit code cleanup #753
Merged
exit code cleanup #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Feb 4, 2025
ikreymer
commented
- use consistent enums for exit codes
- add disk space check on startup and add OutOfSpace exit code (3)
- preparation for Better indicate the interruption reason #584
- use consistent enums for exit codes - add disk space check on startup and add OutOfSpace exit code (3)
tw4l
reviewed
Feb 5, 2025
| BrowserCrashed = 10, | ||
| InterruptedGraceful = 11, | ||
| InterruptedImmediate = 13, | ||
| Fatal = 17, |
There was a problem hiding this comment.
Looking through the code, a lot of the cases where we use this actually match against the other status codes. Maybe we don't need a generic Fatal exception? We're currently using it as a fallback when there's not a more specific status code passed, but probably we could be more precise in most of those cases.
There was a problem hiding this comment.
Maybe this is better handled in #584, on second thought
There was a problem hiding this comment.
Yeah, I think we can add additional statuses via #584, keeping this for backwards compatibility for now.
tw4l
approved these changes
Feb 6, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.