-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection editing revamp #2332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/webrecorder/browsertrix into frontend-collection-editing-dialog
this was causing some edge cases where opening the dialog would leave you with unsaved changes immediately on opening, which was confusing
…om/webrecorder/browsertrix into frontend-collection-editing-dialog
SuaYoo
approved these changes
Feb 11, 2025
ikreymer
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backend changes make sense! Should be good to go!
ikreymer
added a commit
that referenced
this pull request
Feb 12, 2025
…r removed follow up to #2332
ikreymer
added a commit
that referenced
this pull request
Feb 14, 2025
…o optimize loading from correct wacz: - add 'filename' to PageUrlSnapshot on backend - add 'filename' in snapshots on frontend - compute sha-256 of filename (matching wabac.js) and use that as hash
ikreymer
added a commit
that referenced
this pull request
Feb 14, 2025
…o optimize loading from correct wacz: - add 'filename' to PageUrlSnapshot on backend - add 'filename' in snapshots on frontend - compute sha-256 of filename (matching wabac.js) and use that as hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2328
Closes #2338
Tentatively ready for review...? This is a lot of changes, I'll split them out into sections below.
Changes
This is a fairly broad pass over the collection editing and sharing experience, focusing primarily on being able to edit collections from anywhere you might want to edit them (i.e. not just from within their detail page).
As part of these changes, we've removed the previous "metadata" editing dialog, and moved name, summary, thumbnail selection (detailed further below), and visibility into a new dialog that can be access from the org dashboard and the collections list, in addition to the collection detail pages.
Back-end changes
We've added a new
thumbnailSource
field to the Collection model, which preserves the page selected to be collection's thumbnail image. As such, we've separated thumbnail selection from initial replay view selection, though you can still use the initial replay view selection dialog to set the thumbnail if you wish. This field is set via three additional optional query parameters when uploading a thumbnail, and is returned to the client as part of the full collection object.Front-end changes
This PR has changed quite a bit since the start of it & the call & issue that prompted it, I'd initially taken the route of trying to combine all collection editing interfaces into a single dialog, but along the way we figured out that doing so would require either stacked dialogs, which we decided against, or merging the "select archived items" dialog into the editing dialog, which would be a lot more unwieldy state logic to deal with, and potentially confusing options too coming from different places.
There's a few things left to do still:
The current share dialog is still used, and still has visibility & thumbnail selection. This should be removed, and turned into just a dialog with url & embed information.Completed in 8eb179d
We might not get to it this release, but it'd be great to have a button for setting the currently visible page in the replay to the initial replay viewSort of handled 32078be with better error states & messaging, but could be improved on further
Rename "about" and "about this collection" to something having more to do specifically with the description