Skip to content

Add backend validation to prevent adding failed crawls to collection #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add backend validation to prevent adding failed crawls to collection #2930

wants to merge 7 commits into from

Conversation

@tw4l
Copy link
Member

@tw4l tw4l commented Oct 28, 2025 •
edited
Loading

Fixes #2915

  • Check before any collection updates that crawls being added exist and are not failed
  • Ensure collection exists before adding crawls to it

Adds tests for creating and updating collections with a failed item.

@tw4l tw4l force-pushed the issue-2915-failed-crawls-collections-backend branch from 36ca85e to 9cb3cca Compare November 18, 2025 23:13
@tw4l tw4l changed the title WIP: Add backend validation to prevent adding failed crawls to collection Add backend validation to prevent adding failed crawls to collection Nov 19, 2025
@tw4l tw4l marked this pull request as ready for review November 19, 2025 04:34
@tw4l tw4l requested a review from ikreymer November 19, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikreymer ikreymer Awaiting requested review from ikreymer

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task]: Prevent failed crawls from being added to collections via API

2 participants

@tw4l