Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "warcio",
"version": "2.4.3",
"version": "2.4.4",
"keywords": [
"WARC",
"web archiving"
Expand Down
11 changes: 9 additions & 2 deletions src/lib/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,20 @@ export function postToGetUrl(request: Request) {
}

if (query != null) {
request.requestBody = query;
try {
query = decodeURI(query);
} catch (_) {
// just clear out invalid query string
query = "";
}

request.url = appendRequestQuery(
request.url,
decodeURI(query),
query,
request.method,
);
request.method = "GET";
request.requestBody = query;
return true;
}

Expand Down
14 changes: 14 additions & 0 deletions test/testUtils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,20 @@ describe("utils", () => {
);
});

test("post-to-get bad query string", () => {
const request = {
postData: "a=b&c=%ac",
headers: new Headers({"Content-Type": "application/x-www-form-urlencoded"}),
method: "POST",
url: "https://example.com/path/file",
};
const result = postToGetUrl(request);
expect(result).toBe(true);
expect(request.url).toBe(
"https://example.com/path/file?__wb_method=POST&",
);
});

test("surt with www", () => {
expect(getSurt("https://www23.example.com/some/path")).toBe(
"com,example)/some/path",
Expand Down